openstack: No neutron dns#1294
Merged
openshift-merge-robot merged 6 commits intoopenshift:masterfrom Mar 1, 2019
Merged
Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
openshift-ci-robot
added
the
needs-rebase
flaper87
force-pushed
the
no-neutron-dns
branch
from
0f9dea0 to
052d28c
Compare
openshift-ci-robot
removed
the
needs-rebase
flaper87
force-pushed
the
no-neutron-dns
branch
5 times, most recently
from
b9fa4a9 to
82d38f9
Compare
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
Contributor
Author
|
/hold cancel |
flaper87
force-pushed
the
no-neutron-dns
branch
from
82d38f9 to
1e0da5d
Compare
openshift-ci-robot
added
the
needs-rebase
flaper87
force-pushed
the
no-neutron-dns
branch
from
1e0da5d to
e560f45
Compare
openshift-ci-robot
removed
the
needs-rebase
|
/lgtm |
Technically, network names in OpenStack are not unique. We would expect almost every deployment to be using a unique name for its external network, though. In the rare case where you must disambiguate networks, it's possible to specify the UUID via a terraform variable. $ env TF_VAR_openstack_external_network_id="6a32627e-d98d-40d8-9324-5da7cf1452fc" \ > bin/openshift-install create cluster
flaper87
force-pushed
the
no-neutron-dns
branch
from
e560f45 to
d7a4edc
Compare
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flaper87, trown The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/test e2e-aws |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Mar 5, 2019
Through c8b3b55 (Merge pull request openshift#1338 from flaper87/sec-groups-update, 2019-05-01). I've left 8d0847c (openstack: Support setting network UUID via terraform variable, 2018-12-05, openshift#794) undocumented, since it seems like an unstable-enough user-facing API approach that I don't think we want to noise it about and deal with the fall-out when we change the API ;). That commit also made it into this history via 44a9cd3 (openshift#1294). I've also left off eecf496 (openstack: remove neutron dns, 2019-02-19, openshift#1294), because I have no idea what that's about ;). I'll fill in an entry for it later once one of the OpenStack devs explains it to me :p.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've stopped depending on neutron DNS being configured and instead we're fully relying on the CoreDNS instance running on the service VM. This allows us to support more OpenStack clouds, without changing our architecture.